tools/libxl: compile with -Wmissing-declarations
authorIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 17 Aug 2010 16:20:53 +0000 (17:20 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 17 Aug 2010 16:20:53 +0000 (17:20 +0100)
commit8188bc8a37e790fd2f051c2714c2a628d10c1c5e
tree18399ac2156175711a996e81ceebca4e16322533
parentd83eb7f21e37956c1674481b56f0c9181d493304
tools/libxl: compile with -Wmissing-declarations

Since the recent build error caused by mismatch of symbol types due to
missing declarations, build libxl with -Wmissing-declarations.

The patch is mostly straightforward, a one liner in the makefile enables
the flag, a lot of functions in xl_cmdimpl.c needed to be made static
and libxl_paths.c needed to include libxl.h.

The one wart on the patch-set is that flex has a bug where it emits code
with missing declarations for yy(set|get)_column.  This can be worked
around by providing the declarations ourselves regardless.

Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/Makefile
tools/libxl/libxl.c
tools/libxl/libxl_device.c
tools/libxl/libxl_internal.h
tools/libxl/libxl_paths.c
tools/libxl/libxlu_cfg_l.c
tools/libxl/libxlu_cfg_l.h
tools/libxl/libxlu_cfg_l.l
tools/libxl/xl_cmdimpl.c